Using %COMPUTERNAME% question

[chondro]

Hi,
I am in the middle of writing a batchfile to do a bunch of things, but I do not want any of my executions to work on a particular server, if, by chance someone were to execute this on that server.
So what I have done within the batch is exactly below. In the goto:server I just have a message stating that this batch can't be used here and it makes you go back to the menu. It works, but the problem is its working no matter what server I am on, loops me back to the menu no matter what.

Code: Select all

:ERROR
ECHO This can't be run here
pause
GOTO Menu

if "%COMPUTERNAME%"=="MYSERVERNAME"
goto:ERROR

Above is the exact syntax, seems trivial and not a difficult thing to check, but its kicking my butt, and I am new to batch scripting. I have also tried using call instead of if...
Any suggestions?
Thanks in advance!

[Squashman]

The GOTO needs to be on the same line as the IF.

[chondro]

Thanks for he reply, I have tried that and it doesn't make a difference..

[Squashman]

Without seeing all of the actual script it would be hard to troubleshoot.

[foxidrive]

Thanks for he reply, I have tried that and it doesn't make a difference..

It's the correct solution to the syntax error that you showed.

What you have shown above is code that will never be reached.

[trebor68]

I have built here no menu, but it is possible in the block "menu" to build multiple choices.
The GOTO instructions have to be adapted your code, depending on whether you want to jump to menu or program termination.

Code: Select all

@echo off
:menu
echo.
echo   Code block 1 is running.
echo.
goto :begin

:error
echo  This can't be run here.
echo.
pause
rem goto :menu
goto :eof

:begin
echo  This computer is: "%computername%"
if not "%computername%"=="MYSERVERNAME" goto :error

echo.
echo  This is the correct computer.
echo   Code block 2 is running.
echo.

rem goto :eof
rem goto :menu

[Compo]

Code: Select all

if "%COMPUTERNAME%"=="MYSERVERNAME"
goto:ERROR

Try a case insensitive verification:

Code: Select all

If /I "%COMPUTERNAME%"=="MYSERVERNAME" GoTo :ERROR

[chondro]

Thanks for the help guys.. I was able to get it to work by fixing the syntax, went out of the dos window, went back in, started my program.. weird.. appreciate it..