Counter with batch

[gotouser]

Hello,
I'm new to batch and I'm just learning how to do simple things. I wanted to make a simple counter, so tht every time you type in a certain word or number, it would add 1 to the counter. I typed this into the Editor:

Code: Select all

@echo off
setlocal enabledelayedexpansion

:loop
echo test
set a COUNTER=0
set /p NUM=
if %NUM%==1 goto 1
echo !COUNTER!
pause
goto loop

:1
set /a COUNTER=!COUNTER!+1
echo !COUNTER!
pause
goto loop

This works fine, but I don't know why it does. I accidentally typed in "set a" instead of "set /a", but when I corrected it, it no longer worked and just counted up to 1, then got stuck at that number. Why does it work with "set a"?

[gotouser]

Okay, I noticed I made a pretty stupid mistake. Of course, every time it goes to loop, it resets the counter to zero. Got it now

[elzooilogico]

only a note

Code: Select all

set /a COUNTER+=1

is best practice. you don't need any expansion with set /a, and you can make one line calculations

Code: Select all

set /a counter+=1, test=counter%%3, …

.
this is always evaluated left to right, so the left variable reflects the new value of the right one

[pieh-ejdsch]

Code: Select all

set a Counter=0

will create a varName like "a Counter" with Content is 0

Code: Select all

set Counter=0

will create a varname like "Counter" with Content is 0

Code: Select all

set /a Counter = 0

will use all Arithmetic operations to create or/and calculate with Content.

[elzooilogico]

Code: Select all

set a Counter=0

will create a varName like "a Counter" with Content is 0

Good catch! I totally miss that!

[gotouser]

Thank you, now I understand it