DosTips.com

Aacini wrote: ↑

28 Feb 2022 16:33

hi Aacini,
i need your kind help. I am trying to use your code to avoid calling jrepl.bat.
Your code works but now i need to do the string replacements using variable strings passed from the batch portion.
The code below is your code modified. I see parameters are passed to the jscript portion but the search is not working and so the replace is not made.
var Findchr is correctly populated, no error arises but replace is not made.
I tried to .split Finchr to create an array but this also doesnt work.
Pls a little help needed...


Note: this is a portion of the main batch file. The batch code with the csript command belongs to a called function

@if (@X)==(@Y) @end /* Harmless hybrid line that begins a JScript comment
@echo off

rem we are inside a called function...
rem qui le variabili
set Infile="D:\beiaard\Beiaard_3.organ"
set Outfile="D:\beiaard\Beiaard_3.organ.new"
set findchr="\.\\|\.\/|\\\\|image=\\"
set replchr="""|""|""|image="

rem here starts a for /f loop on all .organ text files in a folder
cscript //nologo //E:JScript "%~F0" < %Infile% > %Outfile% %findchr% %replchr%
rem move /y Outfile Infile>nul
goto :EOF

************* JScript portion **********/
// Read all file contents
args = WScript.Arguments;
Findchr=args(0);
Replchr=args(1);


// log_start
var ForReading = 1, ForWriting = 2, ForAppending = 8;
var fso = new ActiveXObject("Scripting.FileSystemObject");
// Open the file for output.
var filename = "d:\\jslog.txt";
var f = fso.OpenTextFile(filename, ForWriting, true);
// Write to the file.
f.WriteLine("Findchr = " + Findchr);
f.WriteLine("Replchr = " + Replchr);
f.Close();
// log_end


var Contents = WScript.StdIn.ReadAll();

// First pass: replace substrings in *all* file contents
var repl = new Array();
repl["\.\\"] = "";
repl["\.\/"] = "";
repl["\\\\"] = "";
repl["image=\\"] = "image=";
repl["Per Zacharias Strand\\"] = ""

// also trying to build array from string with .split does not work
// var FindArray=new Array();
// var ReplArray=new Array();
// var FindArray = Findchr.split("|");
// var ReplArray = Replchr.split("|");

// this works but i need to use Findchr (= strings from batch) not fixed strings inside jscript...
Contents = Contents.replace(/\.\\|\.\/|\\\\|image=\\|Per Zacharias Strand\\/gi, function (A) {return repl[A]});

// this does not work strings not replaced
// Contents = Contents.replace(/Findchr/gi, function (A) {return repl[A]});

// Second pass: replace substrings in line-by-line basis
var lines = Contents.split("\r\n");
for ( var i = 0; i < lines.length; i++ ) {
var line = lines;
if ( line.search(/\.png|\.jpg/i) >= 0 ) {
line = line.replace(/\//g,"\\");
}
WScript.Stdout.WriteLine(line);
}

paolo2504 wrote: ↑

08 Mar 2022 12:47

Aacini wrote: ↑

28 Feb 2022 16:33

hi Aacini,
i need your kind help. I am trying to use your code to avoid calling jrepl.bat.
Your code works but now i need to do the string replacements using variable strings passed from the batch portion.
The code below is your code modified. I see parameters are passed to the jscript portion but the search is not working and so the replace is not made.
var Findchr is correctly populated, no error arises but replace is not made.
I tried to .split Finchr to create an array but this also doesnt work.
Pls a little help needed...


Note: this is a portion of the main batch file. The batch code with the csript command belongs to a called function

@if (@X)==(@Y) @end /* Harmless hybrid line that begins a JScript comment
@echo off

rem we are inside a called function...
rem
set Infile="D:\beiaard\Beiaard_3.organ"
set Outfile="D:\beiaard\Beiaard_3.organ.new"
set findchr="\.\\|\.\/|\\\\|image=\\"
set replchr="""|""|""|image="

rem here starts a for /f loop on all .organ text files in a folder ………
cscript //nologo //E:JScript "%~F0" < %Infile% > %Outfile% %findchr% %replchr%
rem move /y Outfile Infile>nul
goto :EOF

************* JScript portion **********/
// Read all file contents
args = WScript.Arguments;
Findchr=args(0);
Replchr=args(1);


// log_start
var ForReading = 1, ForWriting = 2, ForAppending = 8;
var fso = new ActiveXObject("Scripting.FileSystemObject");
// Open the file for output.
var filename = "d:\\jslog.txt";
var f = fso.OpenTextFile(filename, ForWriting, true);
// Write to the file.
f.WriteLine("Findchr = " + Findchr);
f.WriteLine("Replchr = " + Replchr);
f.Close();
// log_end


var Contents = WScript.StdIn.ReadAll();

// First pass: replace substrings in *all* file contents
var repl = new Array();
repl["\.\\"] = "";
repl["\.\/"] = "";
repl["\\\\"] = "";
repl["image=\\"] = "image=";
repl["Per Zacharias Strand\\"] = ""

// also trying to build array from string with .split does not work
// var FindArray=new Array();
// var ReplArray=new Array();
// var FindArray = Findchr.split("|");
// var ReplArray = Replchr.split("|");

// this works but i need to use Findchr (= strings from batch) not fixed strings inside jscript...
Contents = Contents.replace(/\.\\|\.\/|\\\\|image=\\|Per Zacharias Strand\\/gi, function (A) {return repl[A]});

// this does not work strings not replaced
// Contents = Contents.replace(/Findchr/gi, function (A) {return repl[A]});

// it could be also acceptable not to pass variables
// however I could have many repl[…] items…
// how declare all “repl” items and use a single cumulative or array var in the search ?


// Second pass: replace substrings in line-by-line basis
var lines = Contents.split("\r\n");
for ( var i = 0; i < lines.length; i++ ) {
var line = lines;
if ( line.search(/\.png|\.jpg/i) >= 0 ) {
line = line.replace(/\//g,"\\");
}
WScript.Stdout.WriteLine(line);
}

paolo2504 wrote: ↑

10 Mar 2022 14:45

Antonio,
foa i do appreciate your help. I also understand your words about reading first post (done!) and what to do writing post. I'll try to do my best.
First of all a quick explanation of what i'm doing.
A free Organ virtual simulator named GrandOrgue is able to use samplesets of real organs around the world. The configuration file is text file with section, keys and values; basically a .ini file.
Samplesets are often created in linux systems and contain characters somehow not compatible in Windows: think to paths for example (./xxx/yyy/... that in Windows must be \xxx\yyy\...).
I wrote a batch that makes lot of things (not necessary to explain now); one of the function is called to 'clean' the sampleset configuration file and convert it to a format readable in Windows 10.
That's all. With jrepl i do the 95% of the job in a quick way. I was trying to optimize code when i read your post: you gave the idea to insert jscript code ... and so here we are...
Here below a test configuration file (build from real one for testing), itself replaced and my last code. I fully reviewed code even before your last post. It works, basically it's quite similar to yours. There is only a problem with object.keys: i can't use this method because i get error property or method not supported so i use the standard way (but i would prefer to use, if possible, the one with objectkeys.
PS. solved issue with Image=...

best regards.