DosTips.com

cd "%userprofile%\documents\Ogre Slayer"
if exits "Type Files" goto FileTransfer
if not exist "Type Files" goto FileInput
:FileInput
md "Type Files"
:FileTransfer
cd "%userprofile%\documents\Ogre Slayer\Type Files"
if exists "Haxs4Life.txt" goto TxtInput
if not exists "Haxs4Life.txt" goto TxtTransfer
:TxtTransfer
cd "%userprofile%\desktop\Ogre Slayer\Files"
if exists "Files" goto TxtTransfer1
if not exists "Files" goto TxtTransfer2
:TxtTransfer1
move /-y "%userprofile%\desktop\Ogre Slayer\Files\Haxs4Life.txt""C:\Users\Austin\Documents\Ogre Slayer\Type Files"
goto TxtInput
:TxtTransfer2
cd "%userprofile%\downloads\Ogre Slayer"
if exists "Ogre Slayer" goto TxtTransfer3
if not exists "Ogre Slayer" goto TransferError
:TxtTransfer3
move /-y "%userprofile%\downloads\Ogre Slayer\Files\Haxs4Life.txt""C:\Users\Austin\Documents\Ogre Slayer\Type Files"
goto TxtInput
:TransferError
@echo off
cls
color c4
echo Warning! Warning! Warning! Warning!
Echo An error has been detected!
echo Please read the READ ME!! file in your downloaded file for more info!
echo.
echo Closing game now!...
pause >nul
exit
:TxtInput
cd "%userprofile%\documents\Ogre Slayer\Type Files"
type Haxs4Life.txt
echo.
pause >nul

1.) So I want the bat file to look in the Ogre Slayer folder in documents first
2.) Its going to look for a folder labeled Type Files, if it exists it will go to the FileTransfer process.
3.) If it does not exist it will go to FileInput
4.) At FileInput it should be creating the Type Files folder in the Ogre Slayer folder located in documents.
5.) At FileTransfer it will look for the .txt file labeled Haxs4Life.txt in the Type Files folder.
6.) If its located it will go to TxtInput(which works), if its not found it will go to the TxtTransfer Process.
7.) At the TxtTransfer process it will look for a folder called Files within the Ogre Slayer folder located on the Desktop instead.
8.) If it exists it will go to TxtTransfer1, if not then it just does the same thing at TxtTransfer2 just with the download folder instead.
9.) At TxtTransfer1 i want it to move a .txt file from the specified path to the other, which I don't think is setup correctly here.
10.) From there it finally goes to TxtInput which i know works fine, if all else fails it goes to the error process also, which works fine.

Haxs4Life wrote:if exits "Type Files" goto FileTransfer
if exists "Haxs4Life.txt" goto TxtInput
if not exists "Haxs4Life.txt" goto TxtTransfer

foxidrive wrote:It's more useful to add how it fails and also the error messages.

But on a very brief glance there needs to be a space between the two ""

Code: Select all

\Haxs4Life.txt""C:\Users\

miskox wrote:

Haxs4Life wrote:if exits "Type Files" goto FileTransfer
if exists "Haxs4Life.txt" goto TxtInput
if not exists "Haxs4Life.txt" goto TxtTransfer

You have: EXITs, exists, exists (should be exist everywhere). Start with that.

Saso

Haxs4Life wrote:Its still doing the same thing though sadly :/

Squashman wrote:Definitely see some flawed logic in some of your code. You are checking if FILES exists in FILES. Is there really a file named FILES in the folder named FILES?

Code: Select all

:TxtTransfer
cd "%userprofile%\desktop\Ogre Slayer\Files"
if exist "Files" goto TxtTransfer1
if not exist "Files" goto TxtTransfer2

You do the same thing for Ogre Slayer. Is there a file named Oger Slayer in the Oger Slayer folder?

Code: Select all

:TxtTransfer2
cd "%userprofile%\downloads\Ogre Slayer"
if exist "Ogre Slayer" goto TxtTransfer3
if not exist "Ogre Slayer" goto TransferError

Not sure why you use the goto command when the label is the next line of code.

Some of your code could be rewritten so that it flows better and is more readable.

foxidrive wrote:

Haxs4Life wrote:Its still doing the same thing though sadly :/

If you have changed the code then paste the new version into a reply.

:Intro
Title Ogre Slayer                                                Created By: Haxs4Life
color 06
cls
echo.
echo.
echo.
echo.
echo.
echo.
echo.
echo.
echo                            ----------------------------
echo.
echo                             An Original RPG Batch Game
echo.
echo                              Created and Designed By
echo.
echo                            ----------------------------
echo.
pause
cls
echo.
echo.
echo.
echo.
echo.
echo.
echo.
echo.
cd "%userprofile%\documents\Ogre Slayer"
if exists "Type Files" goto FileTransfer
if not exist "Type Files" goto FileInput

:FileInput
cd "%userprofile%\documents\Ogre Slayer"
md "Type Files"

:FileTransfer
cd "%userprofile%\documents\Ogre Slayer\Type Files"
if exists "Haxs4Life.txt" goto TxtInput
if not exists "Haxs4Life.txt" goto TxtTransfer

:TxtTransfer
cd "%userprofile%\desktop\Ogre Slayer\Files"
if exists "Haxs4Life.txt" goto TxtTransfer1
if not exists "Haxs4Life.txt" goto TxtTransfer2

:TxtTransfer1
move /-y "%userprofile%\desktop\Ogre Slayer\Files\Haxs4Life.txt" "C:\Users\Austin\Documents\Ogre Slayer\Type Files"
goto TxtInput

:TxtTransfer2
cd "%userprofile%\downloads\Ogre Slayer\Files"
if exists "Haxs4Life.txt" goto TxtTransfer3
if not exists "Haxs4Life.txt" goto TransferError

:TxtTransfer3
move /-y "%userprofile%\downloads\Ogre Slayer\Files\Haxs4Life.txt" "C:\Users\Austin\Documents\Ogre Slayer\Type Files"
goto TxtInput

:TransferError
@echo off
cls
title ERROR ERROR ERROR ERROR ERROR ERROR ERROR
color c4
echo.
echo ERROR: The Haxs4Life.txt file cannot be found!
echo.
echo Please read the READ ME!!.txt file in the Ogre Slayer folder for more info!
echo.
echo Closing game now!...
ping -n 3 localhost
exit

:TxtInput
cd "%userprofile%\documents\Ogre Slayer\Type Files"
type Haxs4Life.txt
echo.
pause >nul

Haxs4Life wrote:Ya sorry about that, i wrote this code in a few hurried minutes so its a bit sloppy. Ill go through and make it more smooth later on, im just trying to get it working so i can move on to working on the actual RPG again xP

Compo wrote:Here's a quick untested re-write

Code: Select all

@If Not Exist "%UserProfile%\Documents\Ogre Slayer\" Exit/B
@Echo Off & SetLocal EnableExtensions DisableDelayedExpansion
Title Ogre Slayer Created By: DosTips Community
Color 06
Cls
Echo(&Echo(&Echo(&Echo(&Echo(&Echo(&Echo(&Echo(&Echo(--------------------------
Echo(&Echo(An Original RPG Batch Game&Echo(&Echo(Created and Designed By&Echo(
Echo(--------------------------&Echo(&Pause
Cls
Echo(&Echo(&Echo(&Echo(&Echo(&Echo(&Echo(&Echo(

Set "UPD=%UserProfile%\D"
Set "O_S=\Ogre Slayer\"
Set "FHL=Files\Haxs4Life.txt"
If Exist "%UPD%ocuments%O_S%Type %FHL%" GoTo :TxtInput
If Not Exist "%UPD%esktop%O_S%%FHL%" (
   If Not Exist "%UPD%ownloads%O_S%%FHL%" (GoTo :TransferError) Else (
      GoTo :TxtTransfer2))

:TxtTransfer1
If Not Exist "%UPD%ocuments%O_S%Type Files\" MD "%UPD%ocuments%O_S%Type Files"
Move "%UPD%esktop%O_S%%FHL%" "%UPD%ocuments%O_S%Type Files"
GoTo :TxtInput

:TxtTransfer2
If Not Exist "%UPD%ocuments%O_S%Type Files\" MD "%UPD%ocuments%O_S%Type Files"
Move "%UPD%ownloads%O_S%%FHL%" "%UPD%ocuments%O_S%Type Files"
GoTo :TxtInput

:TransferError
Title ERROR ERROR ERROR ERROR ERROR ERROR ERROR
Color C4
Cls
Echo(&Echo(ERROR: The Haxs4Life.txt file cannot be found!&Echo(
Echo(Please read the READ ME!!.txt file in the Ogre Slayer folder for more info
Echo(&Echo(Closing game now!...
Ping -n 3 127.0.0.1 1>Nul
Exit/B

:TxtInput
Type "%UPD%ocuments%O_S%Type %FHL%"
Echo(&Pause>Nul

Does it help?

Squashman wrote:

Haxs4Life wrote:Ya sorry about that, i wrote this code in a few hurried minutes so its a bit sloppy. Ill go through and make it more smooth later on, im just trying to get it working so i can move on to working on the actual RPG again xP

It is more than sloppy. It is just plain lazy. You haven't even bothered to fix any of the problems we have already found for you. We don't come here to waste time. We come here to help people learn and we get satisfaction of the end result. If you are just going to waste everyone's time then don't bother posting any more code. Please USE CODE TAGS when posting code.

Haxs4Life wrote:With a few changes this works perfect! Thank you so much!

• What is the task - typing a text file called Haxs4Life.txt
• Does the file to be typed exist in the required location
  • Yes - go to the typing of the file
  • No - Does the file exist in either of the two other locations
    • No - go to error message
    • Yes - Move the file from said location to required location, (create required location if it doesn't exist), and type it

Squashman wrote:We did tell you how to make it better and you totally ignored our suggestions with your 2nd code post. If you were in our position what would you say? How can you learn if you just ignore our suggestions.

Compo wrote:

Haxs4Life wrote:With a few changes this works perfect! Thank you so much!

Since my script didn't make any changes from your original intent, (other than one Title), would you mind posting your changes!

As you say you are hoping to learn, here is the breakdown of how I went about the task:

• What is the task - typing a text file called Haxs4Life.txt
• Does the file to be typed exist in the required location
  • Yes - go to the typing of the file
  • No - Does the file exist in either of the two other locations
    • No - go to error message
    • Yes - Move the file from said location to required location, (create required location if it doesn't exist), and type it