DosTips.com

I'm trying to develop a fantasy league draft manager. I want it to color code players that get picked. The program seems to slow down when several players are selected. Any good ways to optimize this? I already feel like I am going to need a billion goto statements to update every players status.

alot of what your doing to control choices could be achived with the actual choice command. Additionally, the labels may be uneccessary if the commands being enacted within the label are simple enough. You could instead Assign a command or group of commands to an indexed variable as a macro.

A couple of pointers:

The syntax for If condition testing when comparing strings Should be: or With the /I switch used when case is to be ignored: If /I "string"=="value" ...

This syntax is used as Doublequotes provide an element of protection against 'poison' characters when performing string comparisons - especially important when taking input via Set /P. Characters other than doublequotes do not afford the same certainty regardings the scripts safe execution.

Variable naming conventions:
Variables names should idealy be meaningful to enhance script readability - for yourself and others. If you use a meaningful variable name, you'll know at a glance what it's being used for.
Concise or abbreviated Variable names can be used, and there is an advantage where long/complex scripts are concerned with regards to performance - however remarks at the point of definition describing what they are used to achieve / track will help not only you in keeping track of what different components of your script are for, but in allowing others to read it and understand the purpose of it's component parts without having to chase down what's doing which thing where. - It's definitely worth making the effort in when asking for help /opinions from others.

Script Design:
Begin your script not with code, but with goals. Detail what you want to achieve, what options / menus / features etc you wish to present and list methods / tools or scripting techniques that you can or will use to achieve those outcomes. It'll save you a tonne of time. Once the script is finished, you can do away with the Build plan.

Lastly: Version Control
When implementing Changes, Save and test as a copy.

A few batch techniques for you to research that may enlighten you to ways of handling variables in more powerful way in batch:
- Batch Macro's with parameters
- Command Macro's with Substring Modification
- Functions
----- the above are diferent ways that allow you to reuse blocks of code to handle similar Sets of commands /actions or Data types
In addition to the above techniques, consider developing an undestanding of the diferent ways of processing or using variables in batch, from substring modification to indexed lists and arrays