Help with substring removal

[bigpickle]

Hi. I'm trying to remove a substring " - DASH" from a string but for some reason it's not working. What am I missing here? Thanks for the help!

It's supposed to turn "test - DASH.ogg" into "z-test.mkv".

Code: Select all

for %%A in (*DASH*.ogg) do (
	set outfile=z-%%~nA.mkv
	echo %outfile%
	set outfile=%outfile: - DASH=%
	echo %outfile%
)

Output is:

D:\>(
set outfile=z-test - DASH.mkv
echo
set outfile=- DASH=
echo
)
ECHO is on.

[sst]

Percent variable expansion will take place before execution of the code and it occurs only once within a block of code. So when your code is executing, %outfile% variable is already expanded to nothing (or to whatever it has been defined before that block of code).
Use delayed variable expansion to resolve that.

Code: Select all

setlocal EnableDelayedExpansion
for %%A in (*DASH*.ogg) do (
	set outfile=z-%%~nA.mkv
	echo !outfile!
	set outfile=!outfile: - DASH=!
	echo !outfile!
)

[bigpickle]

That worked, thank you for the quick help sst!